Zeldruck / Albion-Online-ZQRadar

Free Albion Online Radar
https://discord.gg/xpbgq7E9ya
4 stars 0 forks source link

feat: implement item image download on the fly #9

Open lazycoderz1 opened 5 months ago

lazycoderz1 commented 5 months ago

Implement image download on the fly

Hi @Zeldruck , this update will make the app download the required item images on the fly, utilizing the albion render service and saving them into the filesystem https://wiki.albiononline.com/wiki/API:Render_service

please help to review them if it's worth to be included in the main branch hopefully this will help to reduce the setup effort, cheers

Zeldruck commented 5 months ago

I'm not sure that this is a feature that everyone wants, as it can create lag and make items take longer to appear. Would it be possible to put a checkbox to activate it or not? And if not, target the PR to dev and I'll take care of it

lazycoderz1 commented 5 months ago

@Zeldruck apologize for only responding now, been quite bussy irl recently yeah i agree it add quite some overhead to the image loading method and i agree it's better to make it as optional I have just added the checkbox for it, thanks