search

ZeligsoftDev / CX4CBDDS

CX4CBDDS component modeling and generation tool
Apache License 2.0
8 stars 5 forks source link

Issue #419: update 2.1.x maintenance branch to 2.1.2 #420

Closed elder4p closed 2 years ago

elder4p commented 2 years ago

Setup up 2.1.2 builds on streams/v2.1.x-maintenance branch.

J17359 commented 2 years ago

Is there no automated build associated with this PR? It would be nice to see the artifacts produced with the new versions as a double check that nothing breaks :)

elder4p commented 2 years ago

Is there no automated build associated with this PR? It would be nice to see the artifacts produced with the new versions as a double check that nothing breaks :)

@17359: Just checked. There isn't. I'll update the rules to include the maintenance branches.

elder4p commented 2 years ago

@J17359 : There we go. Build has started. Once you've confirmed all the artifacts are OK, I'll make a similar change on the 'papyrus' branch so that this behaviour will carry forward when we next create a maintenance branch.

elder4p commented 2 years ago

@J17359 : Also adding you as an official reviewer of this pull request. Once you are satisfied, please give your +1. Thanks.

elder4p commented 2 years ago

@J17359 : I notice the papyrus 4.4.0 patch feature is still 2.1.0. Do we care? There has, of course, been no change there. Have you checked the RPM? I know I changed the version, but I do not trust myself on anything RPM.

J17359 commented 2 years ago

@J17359 : I notice the papyrus 4.4.0 patch feature is still 2.1.0. Do we care? There has, of course, been no change there. Have you checked the RPM? I know I changed the version, but I do not trust myself on anything RPM.

Yes the RPM looks good!

As for the papyrus patch, I don't have a personal preference really. If it's not too much work, maybe roll it to 2.1.2 for consistency's sake? We must have missed rolling it to 2.1.1 when we did the initial version bump on that streams branch.

elder4p commented 2 years ago

@J17359 , @ysroh : I have updated the pull papyrus patch version to 2.1.2. Build runs successfully, so I will merge.