ZelionGG / XIV_Databar-Continued

Continuation of XIV_Databar addon
https://discord.gg/g7JZNGSU32
GNU General Public License v3.0
5 stars 3 forks source link

[Bug] Chat Icon throws a LUA error #37

Closed amw83 closed 2 months ago

amw83 commented 3 months ago

Describe the bug When you attempt to click the chat bubble icon you get thrown a LUA error, and nothing happens.

To Reproduce Steps to reproduce the behavior:

  1. Click on the Chat Bubble Icon in the bottom left hand corner.

Expected behavior TBH, I have no idea

Lua error logs Message: ...ns/XIV_Databar_Continued/Mainline/modules/travel.lua:645: attempt to call global 'GetSpellCooldown' (a nil value) Time: Sun Aug 18 15:55:15 2024 Count: 7 Stack: ...ns/XIV_Databar_Continued/Mainline/modules/travel.lua:645: attempt to call global 'GetSpellCooldown' (a nil value) [string "@Interface/AddOns/XIV_Databar_Continued/Mainline/modules/travel.lua"]:645: in function `ShowTooltip' [string "@Interface/AddOns/XIV_Databar_Continued/Mainline/modules/travel.lua"]:209: in function <...ns/XIV_Databar_Continued/Mainline/modules/travel.lua:206>

Locals: self =

{ hearthFrame = TravelModule { } portButtons =
{ } modules =
{ } baseName = "XIV_Databar_Continued" defaultModuleState = true selectedHearthstones =
{ } extraPadding = 30 enabledState = true hearthButton = hearthButton { } garrisonHearth = 110560 useElvUI = true defaultModuleLibraries =
{ } portOptions =
{ } iconPath = "Interface\AddOns\XIV_Databar_Continued\media\datatexts\repair" orderedModules =
{ } portOptionString = FontString { } portPopup = portPopup { } portText = FontString { } portIcon = Texture { } hearthText = FontString { } hearthIcon = Texture { } optionTextExtra = 4 availableHearthstones =
{ } name = "XIV_Databar_ContinuedTravelModule" portButton = portButton { } moduleName = "TravelModule" hearthstones =
{ } } r = 1 g = 0.486275 b = 0.039216 = nil (for state) =
{ 193753 =
{ } 110560 =
{ } 140192 =
{ } } (for control) = 193753 i = 193753 v =
{ text = "The Dreamgrove" portId = 193753 } (temporary) = nil (temporary) = 193753 (*temporary) = "attempt to call global 'GetSpellCooldown' (a nil value)" xb =
{ defaults =
{ } modules =
{ } baseName = "XIV_Databar_Continued" fontFlags =
{ } defaultModuleState = true frames =
{ } miniTextPosition = "TOP" db =
{ } enabledState = true Changelog =
{ } name = "XIV_Databar_Continued" orderedModules =
{ } LSM =
{ } constants =
{ } timerRefresh = true defaultModuleLibraries =
{ } L =
{ } } L =
{ Show XP Bar Below Max Level = "Show XP Bar Below Max Level" Right = "Right" Second Currency = "Second Currency" Cleaned = "Cleaned" Currency Select = "Currency Select" Enable Loadout Switcher = "Enable Loadout Switcher" Left-Click = "Left-Click" Bottom = "Bottom" Whisper BNet = "Whisper BNet" Show Pets Button = "Show Pets Button" Use Server Time = "Use Server Time" Hide Event Text = "Hide Event Text" Addons to Show in Tooltip = "Addons to Show in Tooltip" Open Artifact = "Open Artifact" Hide order hall bar = "Hide order hall bar" Hide BNet App Friends = "Hide BNet App Friends" Show Character Button = "Show Character Button" Local Time = "Local Time" Master Volume = "Master Volume" Whisper Character = "Whisper Character" Ready = "Ready" Hide Bar in combat = "Hide Bar in combat" Durability Warning Threshold = "Durability Warning Threshold" Use Class Colors for XP Bar = "Use Class Colors for XP Bar" Bar Position = "Bar Position" Use Class Color for Text = "Use Class Color for Text" Module Spacing = "Module Spacing" Show Chat Button = "Show Chat Button" Empty Hearthstones List = "If you see an empty list, /reload your UI a few seconds after the initial loading (Blizzard is loading items informations asynchronously so that's the only solution for now)." Modifier for friend invite = "Modifier for friend invite" Changelog = "Changelog" Bar Color = "Bar Color" Icon Spacing = "Icon Spacing" %month%-%day%-%year% = "%month%-%day%-%year%" Port Options = "Port Options" Social Text Offset = "Social Text Offset" Hover = "Hover" Current Specialization = "Current Specialization" Toggle Profession Spellbook = "Toggle Profession Spellbook" Travel = "Travel" Show Talents Button = "Show Talents Button" Colors =

Screenshots If applicable, add screenshots to help explain your problem.

WoW Version (please complete the following information)

XIV_Databar Continued Version Which version of XIV_Databar Continued are you using ? Current

Additional context Add any other context about the problem here.

ZelionGG commented 3 months ago

Heya, thank you for the report, I was on vacation for the last 3 weeks ! I'll investigate these issues today.

ZelionGG commented 3 months ago

I'm really wondering if that button is of any use to someone. I feel like ppl are typing in chat to select the channel they want to use else they use the in-game button / ElvUI chat button.... Taking any feedbacks if some ppl use that little button on XIV

amw83 commented 3 months ago

I'm really wondering if that button is of any use to someone. I feel like ppl are typing in chat to select the channel they want to use else they use the in-game button / ElvUI chat button.... Taking any feedbacks if some ppl use that little button on XIV

To be honest, I have no idea what it's even supposed to do :D ... New to tha addon, and just noticed the issue, and since it errors and doesn't work, I had no idea what it was even intended for ... haha, did it just hide the chat window?

ZelionGG commented 3 months ago

I'm really wondering if that button is of any use to someone. I feel like ppl are typing in chat to select the channel they want to use else they use the in-game button / ElvUI chat button.... Taking any feedbacks if some ppl use that little button on XIV

To be honest, I have no idea what it's even supposed to do :D ... New to tha addon, and just noticed the issue, and since it errors and doesn't work, I had no idea what it was even intended for ... haha, did it just hide the chat window?

The goal of this button is to allow you to change the chat channel rapidly just like when you click the standard "bubble" on the left of the default Blizzard Chat, but I really doubt that this button is really used by anyone...

image

I found a fix for that button anyway but I really don't know if I really need to keep this functionality.

ZelionGG commented 2 months ago

Heya, chat icon shouldn't throw errors anymore with v3.0.3, let me know if that's the case !

Thank you again.