search

ZelionGG / XIV_Databar-Continued

Continuation of XIV_Databar addon
https://discord.gg/g7JZNGSU32
GNU General Public License v3.0
5 stars 3 forks source link

[Bug] Underscore Throwaway Value from other addons is being treated as an Input #41

Closed RealoFoxtrot closed 2 months ago

RealoFoxtrot commented 2 months ago

Describe the bug The short description: I have found that XIV is causing to be treated as an input instead of a throwaway value. At least this has happened when using the command SendChatMessage, with being used to ignore the language input

To Reproduce Steps to reproduce the behavior:

  1. Load the game wiht XIV databar working
  2. type /script SendChatMessage("Test","SAY",_,_)
  3. View message "You Cannot Speak That Language"

Expected behavior What should happen is _ should be treated as a throwaway character and ignored, sending the message anyhow.

Lua error logs No LUA error

Screenshots If applicable, add screenshots to help explain your problem.

WoW Version (please complete the following information)

XIV_Databar Continued Version Which version of XIV_Databar Continued are you using ? 3.0.3

Additional context Add any other context about the problem here. I am sure this is XIV as I have disabled all addons except XIV and then turned it off and it is definitely XIV that is causing this behavior. I have no clue what could be causing it though. However, the solution for addon/Scripters is to use nil instead of _

ZelionGG commented 2 months ago

Heya, interesting feedback, I identified the bug and that is caused by variables reassignments like self.cook.name, self.cook.defIcon, self.cook.lvl, self.cook.maxLvl, _, _, self.cook.id, _ = GetProfessionInfo(self.cook.idx)

It is happening in multiple modules, I identified all of the faulty reassignments and this should be fixed in the next release !

Thank you for letting me know about that strange interaction !

ZelionGG commented 2 months ago

Heya, after such a long wait, version 3.1 is out and should fix that issue !

Let me know if you still have a problem !

Thank you again for the feedback and for helping me maintain XIV Databar Continued and enjoy !

RealoFoxtrot commented 2 months ago

Seems like it's fixed it!

ZelionGG commented 2 months ago

Sweet, thank you again for the report and enjoy !