Zemaneh-Yosef / royzmanimwebsite

Improved website based on Elyahu41.github.io/RabbiOvadiahYosefCalendar/
3 stars 2 forks source link

Auto Mode - Shabbat Mode replacement #12

Open NightScript370 opened 1 year ago

NightScript370 commented 1 year ago

The current implementation of Shabbat Mode mirrorly increments the screens y position by about 3 px every absolute 50mil, which makes for a non-smooth scrolling. The indicator that this isn't a bug but rather a feature is with an absolute positioned banner on the top that reads Shabbat mode as long as the 5 times the text is defined wouldn't disappear if your screen is too wide because a 6th element wasn't added. To disable this, you first need to click on the banner to disable it, then get the screen to scroll to the nav bar and finally disable it from there... ...needless to say, this did not take into account the recent advancements we made for desktop users. With all the horizontal width we take advantage of, there is no scrolling that could happen on a 1440p screen. As such, only the fact that there is a blue bar is the indicator.

To fix this, I would like to rename Shabbat Mode to "Auto Mode", which would be inclusive of Yom Tov and convey the purpose in the name. With that, there would actually be three implementations: