search

Zemaneh-Yosef / royzmanimwebsite

Improved website based on Elyahu41.github.io/RabbiOvadiahYosefCalendar/
3 stars 2 forks source link

Use media queries for dark theme #7

Open NightScript370 opened 1 year ago

NightScript370 commented 1 year ago

The browser already does the heavy lifting for us. It is rather pointless to implement it ourselves

NightScript370 commented 1 year ago

This is implemented Should we implement an override for browsers that do not implement the proper media queries?

Elyahu41 commented 1 year ago

Ideally, yes. We want to support as many browsers as possible. Also, it is recommended practice to mention the commit that fixed the issue in the discussion, as github will automatically detect it. Like so: issue #11 and the commit 1e7cc16