Getting devolpment in sync

Zen4All-nl / Zen-Cart-Dynamic-Price-Updater

The Dynamic Price Updater is a module for Zen Cart that automatically updates the price display on product pages when a visitor changes an attribute or adjusts the cart quantity

GNU General Public License v2.0

2 stars 4 forks source link

Getting devolpment in sync #9

Open Zen4All opened 4 years ago

Zen4All commented 4 years ago

@mc12345678 , @dbltoe, and @torvista

The 4 of us have been active with development of the Dynamic Price Updater module in past years. I have been absent on this one, and mc12345678 has taken over the latest version(s).

I have seen you guys all did your own coding, and updates, but I would like to sync that back in to 1 repo. Today I made a development branch, to which you can make pr's. The changes I made so far are:

moving the class code from includes/classes/dynamic_price_updater.php to includes/classes/ajax/zcDPU_Ajax.php
Removing the ancient code, using JSON or XML, and replaced it with the build in native Zen Cart Ajax functionality
Drop support for ZC versions <1.5.6
PHP version >= 5.6
Updated optional jquery version to 3.4.1
Bumped the Module version to 4.0.0 Beta 1

I am working on some proper documentation.

torvista commented 4 years ago

Thanks, I'm getting bogged down in pending PR panic, but I'll try.

Zen4All commented 4 years ago

Thanks, I'm getting bogged down in pending PR panic, but I'll try.

:smile: You may also point me to the changed code, and I'll merge it for you

torvista commented 4 years ago

ok, I've put my code on my fork. I can't say how much real changes there are, I fixed what I needed at the time, but didn't go any further. It was too complicated with the forks.

Zen4All commented 4 years ago

@torvista thx I'll have a look. I also had a look at MC's fork, but he has so many branches, I have no clue where to start :laughing:

torvista commented 4 years ago

I have no clue where to start Exactly. That was why I didn't feed back anything. I think I used his latest one which fixed the problems I had. Mine still has the specials problem, but I managed to mask it somehow.

mc12345678 commented 4 years ago

Been updating to the branch that is "latest" when viewing the insights tab.

Zen4All commented 4 years ago

@torvista Your updates have been merged in to Beta2 @mc12345678 I'll have a look, and put it in to the next beta

mc12345678 commented 4 years ago

Note that if making this applicable to ZC 1.5.6 and above that ajax.php in the root of the install should be deleted as that file is maintained by ZC versions and is unnecessary in this package regardless of how one got to this version of the plugin.

Zen4All commented 4 years ago

@mc12345678 Your updates have been merged into beta3. How confident atre you that your changes were ready for production?