search

ZenGo-X / curv

Rust language general purpose elliptic curve cryptography.
MIT License
264 stars 111 forks source link

Fix clippy warnings #104

Closed tobin-crypto closed 3 years ago

tobin-crypto commented 3 years ago

Currently we have a bunch of Clippy warnings. This PR removes all of them including those found with Clippy nightly.

This is my first PR to curv! If there is anything I've missed by way of contributing etiquette please say so. This is also my first PR with my company github account (I'm tcharding usually), we are using curv at work so I thought I'd try push some improvements upstream :)

Thanks, Tobin.

survived commented 3 years ago

I've also updated travis config, so clippy warnings would be noticed by CI

tobin-crypto commented 3 years ago

I've also updated travis config, so clippy warnings would be noticed by CI

Awesome, thanks. I could have done that ...

survived commented 3 years ago

Awesome, thanks. I could have done that ...

Sorry, I just did it reflexively 😅

survived commented 3 years ago

Thank you again, @tobin-crypto! The code's got more clean. @omershlo can we merge it?

omershlo commented 3 years ago

great work @tobin-crypto !

tobin-crypto commented 3 years ago

Thanks for the reviews @survived and thanks for merging @omershlo. Nice to upstream some patches!