ZenGo-X / curv

Rust language general purpose elliptic curve cryptography.
MIT License
264 stars 111 forks source link

Failing to build because of missing dependency version #112

Closed alexbouez closed 3 years ago

alexbouez commented 3 years ago

I am unable to build with cargo because of a missing dependency "zeroize 0.10" which has been removed, Newer versions are available (1.3.0, 1.2.0, 1.1.1).

omershlo commented 3 years ago

Thanks @alexbouez ! We are aware and @survived is working on a fix. We will update shortly !

omershlo commented 3 years ago

Hi, fix is taking some time, Please try to work on one of the earlier tags instead of latest.

alexbouez commented 3 years ago

Hello, thank you for your help,

A quick fix that works for me is downloading a local version of zeroize (for example from crates), changing its version tag to "0.10.1" and adding a line to the Patch manifeset in Cargo.toml: zeroize = { version = "0.10.1", path = "zeroize" }

I am running cargo version 1.53.0-nightly on VSCode. Current repo commit a072793725f279f467d0e9f81480afc27cf5f17a

survived commented 3 years ago

Hi @alexbouez, please check if #113 solves the issue (try tag v0.6.2)

vherbert commented 3 years ago

Hello!

I meet the same build error, but I use feature ["ec_ed25519"] and tag v0.6.2 does not have this feature.

Thanks for your help.

survived commented 3 years ago

Hi @vherbert, all features were removed from curv in past versions. We used to choose EC point implementation by specifying a feature, now all curve implementation are available in curv::elliptic::curves::*, and all structures and algorithms are generic over choice of curve (ECPoint trait). I.e. curv API has been changed and some manual actions are required to move on next version.

vherbert commented 3 years ago

Ok, thx. It is maybe not the good place to say it but this old feature is still employed in current version of multi-party-eddsa.

omershlo commented 3 years ago

thanks @vherbert - It would be great if you could update multi-party-eddsa repo? otherwise - please open an issue

survived commented 3 years ago

Right, multi-party-eddsa has not been updated yet

survived commented 3 years ago

I believe this issue should be closed - zeroize dependency updated