Remove dependency on rust-crypto

survived commented 3 years ago

Removes deprecated dependency on rust-crypto. The only thing is changed in the library is merkle tree support.

Changed the lib providing merkle tree support: merkle-sha3 v0.1 → merkle v1 \ (merkle-sha3 is abandoned)
Merkle trees support is optional \ merkle crate depends on ring. Dependency on ring might be not desirable, so I made it optional. See feature merkle-tree.
Changed the hash function used by merkle proofs: keccak256 → sha256 \ ring has no support of keccak256. This change means that any proofs generated by earlier versions of curv are not compatible with the latest curv.

elichai commented 3 years ago

idk, ring is quite big to take in just for sha256. Maybe we should fork/implement one of the merkle libraries? Or maybe use this? https://github.com/nervosnetwork/merkle-tree (it allows us to use whatever hash function we want)

survived commented 3 years ago

merkle-cbt looks fine to me! I changed the code to use this crate, now we have no dependency on ring! 🎉

But in favour of this dependency switching, I had to change merkle trees API, and proofs generated by previous curv still are not compatible with latest curv. But I think it's fine.

ZenGo-X / curv

Remove dependency on rust-crypto #137