search

ZenGo-X / curv

Rust language general purpose elliptic curve cryptography.
MIT License
264 stars 111 forks source link

Add generate_random_point(), bump patch version. #148

Closed tmpfs closed 2 years ago

survived commented 2 years ago

Can I ask you to move this function to curv::elliptic::curves::secp256k1::hash_to_curve module? (you'll need to create a new module hash_to_curve). I find this relocation suitable since the function is specific to secp256k1 curve. Also I'd like to replace it with different more generic hash-to-curve implementation in near future, so it's better to keep it deeper for now 🙂

tmpfs commented 2 years ago

Sure thing @survived, that is done :+1:

elichai commented 2 years ago

Thanks for the PR!

tmpfs commented 2 years ago

@survived, I was hoping to get a patch version published at 0.8.3 then to update bulletproofs and centipede to use this version of generate_random_point() but when I pull master I notice the version has been updated to 0.9.0 and the published crate is at 0.8.2.

Whats the best way to proceed?

survived commented 2 years ago

@tmpfs I'm releasing v0.8.3 with your patch right now, but I'd like to update all crates to use v0.9. No changes are required (besides switching on curv's generate_random_point()). I can update all the PRs on my own