search

ZenGo-X / curv

Rust language general purpose elliptic curve cryptography.
MIT License
264 stars 111 forks source link

Bump p256 to 0.11 #168

Closed Be-P closed 1 year ago

Be-P commented 2 years ago

I've bumped the p256 dependency to version 0.11.1 and fixed some compilation issues. See #166

tmpfs commented 1 year ago

Please can we land this I want to use the latest version of p256 in dependents and this is blocking me updating as compilation fails with conflicts on ecdsa-core.

Any help much appreciated as always 🙏

Edit: I am using the workaround in #166 for now - thanks @Be-P 👍

shekohex commented 1 year ago

Please can we land this I want to use the latest version of p256 in dependents and this is blocking me updating as compilation fails with conflicts on ecdsa-core.

Any help much appreciated as always 🙏

Edit: I am using the workaround in #166 for now - thanks @Be-P 👍

Same issue here! Hey @survived, any chance we can have this PR get merged and a new version get published?

Be-P commented 1 year ago

@elichai I've fixed the cargofmt step. The next step that runs cargo clippy -- -D clippy::all, throws errors from various files that were not touched by this PR. Should I go around fixing them?

elichai commented 1 year ago

No need, I'll do that in a separate PR

vnermolaev commented 1 year ago

maintainers, don't you think the crate deserves a version bump to 0.9.1 or something? The problem addressed by this PR still exists for

curv-kzen = "0.9.0"
dsa = "0.4.0"

but does not for

curv-kzen = { git ="https://github.com/ZenGo-X/curv.git" }
dsa = "0.4.0"