search

ZenGo-X / curv

Rust language general purpose elliptic curve cryptography.
MIT License
264 stars 111 forks source link

Write smart tests for hash functions #54

Open omershlo opened 5 years ago

omershlo commented 5 years ago

unit test for hash functions should use test vectors and compare results. Right not we are just doing sanity checking.

amanusk commented 5 years ago

Extending these tests https://github.com/KZen-networks/curv/blob/ab4aed0e13425e8d6ba19819227b60e8085fb701/src/cryptographic_primitives/hashing/hash_sha256.rs#L40

https://github.com/KZen-networks/curv/blob/ab4aed0e13425e8d6ba19819227b60e8085fb701/src/cryptographic_primitives/hashing/hash_sha512.rs#L40

?

omershlo commented 5 years ago

yes