search

ZenGo-X / mpc-over-signal

Secure transport for running MPC protocols backed by Signal
GNU Affero General Public License v3.0
62 stars 11 forks source link

Use libsignal-service-rs ? #5

Open rubdos opened 3 years ago

rubdos commented 3 years ago

Hey! Full disclosure: I'm one of the main people behind https://github.com/Michael-F-Bryan/libsignal-service-rs/. I wonder why you folks rolled your own, and what would be missing in our library such that we can help each other? We already have unidentified senders (#4), for instance.

Want to team up?

survived commented 3 years ago

Hi @rubdos! Actually I simply missed this amazing crate when I was googling something similar. It can significantly simplify our code! My only concern is why are you still using bindings to libsignal-client-c whereas there're great pure Rust implementation of it? For instance, it provides async-friendly stores traits (PreKeyStore, etc). Maybe I can help you with https://github.com/Michael-F-Bryan/libsignal-service-rs/issues/72?

rubdos commented 3 years ago

I thought you would be raising that concern. The only reason is lack of time/putting focus on other things. Please do feel free to help us with https://github.com/Michael-F-Bryan/libsignal-service-rs/issues/72 !

And also, please do feel free to post issues and questions. If you're into Matrix or IRC, feel free to come have a chat on #whisperfish:rubdos.be or #whisperfish on Freenode, it's where we coordinate this effort.

Another unspoken rule: we still very often break public interface in libsignal-service. So if you're patching stuff, feel free to break things!

rubdos commented 3 years ago

FYI, our move to libsignal-client is finishing up: https://github.com/Michael-F-Bryan/libsignal-service-rs/pull/83 ! Join the water, it's warm ;-)

Meanwhile, we've moved to https://github.com/whisperfish/, which encompasses a bunch of third-party Signal libraries, and we're in contact with Signal about moving some primitives over to them.

survived commented 3 years ago

Thank you for keeping up to date! We will switch on libsignal-client shortly after Michael-F-Bryan/libsignal-service-rs#83 is merged

survived commented 3 years ago

we've moved to https://github.com/whisperfish/

I saw all this story with choosing right license (GPLv3 / AGPLv3) and signing CLA. Tricky journey!