ZenGo-X / multi-party-ecdsa

Rust implementation of {t,n}-threshold ECDSA (elliptic curve digital signature algorithm).
GNU General Public License v3.0
966 stars 309 forks source link

Range proofs and moduli sizes checks added #145

Closed DmytroTym closed 2 years ago

DmytroTym commented 2 years ago
DmytroTym commented 2 years ago

This is a big PR so please take your time to review it. A couple of comments:

DmytroTym commented 2 years ago

Haven't reviewed the implementation of the rangeproofs

Yeah, I guess accepting such a sizeable contribution from outside might be scary. This code is however a modification of ING bank's implementation that can be found here: https://github.com/ing-bank/threshold-signatures/blob/master/src/algorithms/zkp.rs. As such, it has been audited by Kudelski. After I finished, I checked that all the computations are the same (except for those which we know should not be) one more time.