search

ZenGo-X / multi-party-ecdsa

Rust implementation of {t,n}-threshold ECDSA (elliptic curve digital signature algorithm).
GNU General Public License v3.0
977 stars 310 forks source link

Question about safe primes in gg20 #178

Open tmpfs opened 2 years ago

tmpfs commented 2 years ago

The create_safe_primes() function calls generate_h1_h2_N_tilde(): https://github.com/ZenGo-X/multi-party-ecdsa/blob/c94065fbf37132dccc7955cf2627866e87c162bf/src/protocols/multi_party_ecdsa/gg_2020/party_i.rs#L179-L199

However, in generate_h1_h2_N_tilde() the call to Paillier::keypair_safe_primes() is commented out: https://github.com/ZenGo-X/multi-party-ecdsa/blob/c94065fbf37132dccc7955cf2627866e87c162bf/src/protocols/multi_party_ecdsa/gg_2020/party_i.rs#L138-L140

Does this weaken the support for safe primes? Is using safe primes still recommended for production?

Thanks for any pointers 🙏