bug fix in party two key gen

ZenGo-X / multi-party-ecdsa

Rust implementation of {t,n}-threshold ECDSA (elliptic curve digital signature algorithm).

GNU General Public License v3.0

982 stars 313 forks source link

bug fix in party two key gen #34

Closed omershlo closed 6 years ago

omershlo commented 6 years ago

maybe related to #31

gbenattar commented 6 years ago

Signature is still failing. Can you please explain what was the bug you fixed? My concern is that you fixed a bug which was not caught by unit test. I would like to have a unit test on that specific, is that something doable?

omershlo commented 6 years ago

I applied your fix on sk size. Nothing new

gbenattar commented 6 years ago

Sure but what about covering the previous bug in unit testing?

gbenattar commented 6 years ago

Waiting for https://github.com/KZen-networks/cryptography-utils/pull/7 to be merged to test properly.