search

ZenGo-X / multi-party-ecdsa

Rust implementation of {t,n}-threshold ECDSA (elliptic curve digital signature algorithm).
GNU General Public License v3.0
975 stars 308 forks source link

v0.1.0 candidate, use tagged versions dependencies #76

Closed oleiba closed 5 years ago

oleiba commented 5 years ago

Note: rocket versions use specific commits, because latest tagged versions of rocket use cookie = "0.11.1" which is dependant on ring = "0.13". This causes a dependancy hell when using this (multi-party-ecdsa) package together with other packages co-depending on ring but on a more advanced version (0.14). Using this commit advances the transitive dependency to ring@0.14 and does not break the dependant repositories (I will follow up on https://github.com/SergioBenitez/Rocket/issues/1072 to see if that's getting into a tagged release on rocket).

jebrosen commented 5 years ago

Do you make use of rocket's tls or private-cookies features? If not, you should be able to set default-features = false on rocket to drop the ring dependency instead and avoid depending on a pinned git revision.

oleiba commented 5 years ago

@jebrosen what a great contribution! I pushed an update to put rocket on version "0.4.2" with default-features = false, and indeed its dependency on ring goes away and the tests go through.