search

ZenGo-X / rust-paillier

A pure-Rust implementation of the Paillier encryption scheme
Other
36 stars 38 forks source link

Remove unused unstable feature custom_attribute #4

Closed djc closed 5 years ago

djc commented 5 years ago

This seems to have been added by @kigawas in #2, but it is not used -- and it prohibits the crate from being used on stable Rust.

djc commented 5 years ago

@omershlo would you mind taking a look? Should be quick.

omershlo commented 5 years ago

@kigawas what was the motivation for adding this line ?

kigawas commented 5 years ago

@omershlo Sorry bros, just added by coincidence.

Reason is related with serde's with

djc commented 5 years ago

So can you update the dependency in zk-paillier and/or tag this?

omershlo commented 5 years ago

yes. (@oleiba )

omershlo commented 5 years ago

done @djc please let me know if that's OK.

djc commented 5 years ago

This is great, although it would be even better if you could also upgrade the curv dependency across these two to the latest one (so I can get the bincode fix in, as well).

omershlo commented 5 years ago

We haven't merge the bincode fix yet...

djc commented 5 years ago

Ah, you're right... never mind then! If it lands, would be great if you could also update these two.

omershlo commented 5 years ago

Of course!