search

ZengineHQ / mayan

Next-generation maya written in NodeJS
3 stars 9 forks source link

implement a `--skip-minify` flag for the build command #17

Closed alexweber closed 6 years ago

alexweber commented 6 years ago

related to #12

AParks commented 6 years ago

does this actually work? It looks like it still calls htmlmin, even if you pass skip-minify, just with fewer options. When I was testing this locally it was already not a prod env, and it was still failing.

alexweber commented 6 years ago

@AParks yeah it works, what do you mean it was failing? I didn't fix the issue related to the HTML linting, that issue is your baby now :) As far as I can tell calling htmlmin without params doesnt do much, on a plugin here im getting -200 lines of HTML in production mode so its doing something... i suppose we can make it not call htmlmin at all in non prod to avoid confusion

alexweber commented 6 years ago

@AParks ^

AParks commented 6 years ago

yea I had some invalid html in there, so the whole build was failing. Now, thanks to this change, you can pass this skip-minify flag as an easy workaround to getting your plugin deployed.