ZengineHQ / mayan

Next-generation maya written in NodeJS
3 stars 9 forks source link

mayan --show-hidden non-zero exit code #20

Closed evert0n closed 4 years ago

evert0n commented 6 years ago
Bravo:test-plugin everton$ mayan --show-hidden ; echo $?
mayan <command>

Commands:
  mayan build [plugin]     Build plugin
  mayan deploy [plugin]    Deploy plugin
  mayan init [plugin]      Initialize plugin
  mayan publish [plugin]   Publish plugin
  mayan register [plugin]  Register plugin in Zengine API

Options:
  --version      Show version number                                   [boolean]
  --env          Environment name
  --config       Path to JSON config file
  --help         Show help                                             [boolean]
  --show-hidden  Show advanced options                                 [boolean]

For more information, RTFM at https://github.com/ZengineHQ/mayan

1
Bravo:test-plugin everton$

Should exit with 0

tehpsalmist commented 5 years ago

@evert0n What are the implications of a non-zero exit code in this scenario?

evert0n commented 5 years ago

it's the normal behavior of command lines apps to exit with 0 when successful, in this case I tried to add a test for this option and the test was failing because of this issue, however the argument/params works as expected

tehpsalmist commented 5 years ago

What is the fix for this? Is there an error that is causing the exit code to be > 0?

tehpsalmist commented 4 years ago

closing due to inactivity. haven't seen an issue with this myself or heard of it from anyone else since. ¯_(ツ)_/¯