search

Zenika-Training / zenika-formation-framework

Tools to build and present our training material
8 stars 25 forks source link

Support some presentation remotes #170

Closed moreau-nicolas closed 7 years ago

moreau-nicolas commented 7 years ago

Some presentation remotes use Left/Right to navigate the slides. By default Reveal uses those for column/chapter navigation. This is far less useful than slide navigation.

This patch lets the presenter use Left/Right to navigate slides, but still Does The Right Thing in overview mode.

We also map the Up/Down arrows for consistency.

hgwood commented 7 years ago

Nice idea. However it means navigation between chapters with left/right will not be possible anymore, and that might disturb quite a few presenters. How about enabling the bindings you're proposing conditionally with a query parameter? Maybe ?remote? What do you think?

moreau-nicolas commented 7 years ago

It is in fact still possible to skip chapters, by using Reveal's "overview mode".

I'm not sure how I feel about using a query parameter. I'll think it over. :)

moreau-nicolas commented 7 years ago

@hgwood I added a query parameter for feature toggling (as you suggested).

I also added a key binding in order to have a more user-friendly way to enable the feature (yes, I'm that lazy :D). The "remote mode" can now be toggled using the [R] key.

I'm unsure as where to document this new feature. The Wiki ? The README ? Somewhere else ?

moreau-nicolas commented 7 years ago

@hgwood please review :)

hgwood commented 7 years ago

@moreau-nicolas I was on leave this week :)

moreau-nicolas commented 7 years ago

@hgwood hope you had a great time :)

hgwood commented 7 years ago

Thanks for your contribution and patience. :)

zigarn commented 3 years ago

@moreau-nicolas : Could you check if this need to be ported on sensei or it's not necessary with RevealJS 4?

moreau-nicolas commented 3 years ago

Just tried the sample on revealjs.com (using 4.1.0) and it does behave the same as older RevealJS releases. This definitely should be ported. I'll do it.