Zenika-Training / zenika-formation-framework

Tools to build and present our training material
8 stars 25 forks source link

Replace PhantomJS by Headless Chrome #185

Closed hgwood closed 7 years ago

hgwood commented 7 years ago

Supersedes #168.

Chrome 59 will support headless mode with pdf printing.

See branch path-to-headless-chrome and #187.

Questions & answers:

PDF generation for slides is done (#187). Need to do the same for labs.

jlandure commented 7 years ago

We could use both: host install and docker image. For CircleCI, it supports a docker run. We could use the official image if exists or build our own image with all the dependencies. Sample circle.yml with docker run commands: https://github.com/Zenika/POC_EasyToGo/blob/master/circle.yml

hgwood commented 7 years ago

Progress today:

need to investigate more:

code is on branch headless-chrome-experiments.

hgwood commented 7 years ago

According to this, PDF printing can be triggered via the remote interface without --print-pdf being there, and that's actually the preferred method.

hgwood commented 7 years ago

PR: #192.