💄 use theme 2017 by default

Zenika-Training / zenika-formation-framework

Tools to build and present our training material

8 stars 25 forks source link

💄 use theme 2017 by default #251

Closed yannbertrand closed 4 years ago

yannbertrand commented 4 years ago

:bug: Use 2017 theme by default for running (npm start/grunt) and pdf generation (npm start pdf/grunt pdf) :sparkles: Add an --old-theme parameter for both commands to use the old theme

yannbertrand commented 4 years ago

Context: Strigo requires slides in PDF format. Right now, we can only generate the old themed PDF.

hgwood commented 4 years ago

Looks good. I'll test it.

hgwood commented 4 years ago

Well, it works. I'm not sure I like the implementation. Having an --old-theme switch solidifies the fact that we support only 2 themes, even though we know that might change. I'd prefer a --theme=<theme> switch. But since this project is being phased out, and your solution is very simple, I'll accept the technical debt.