search

Zenika-Training / zenika-formation-framework

Tools to build and present our training material
8 stars 25 forks source link

Improve 2020 styles guidelines usage #252

Closed yannbertrand closed 4 years ago

yannbertrand commented 4 years ago

Before Senseï release, it would be nice to have a theme that conforms the guidelines better. It's far from perfect but I think it does the job for a temporary usage (I've actually used it "in production" for the Vue.js training).

image image image

zigarn commented 4 years ago

Super :+1:

Par hasard, ce serait compliqué de pouvoir avoir des petites classes question, exclamation, suspension qui mettent le point qui va bien en rouge (avec   en français :stuck_out_tongue:) plutôt qu'un . en plus après un ?, ! ou ... ? (Juste du pinaillage de ma part, c’est très bien comme ça déjà)

yannbertrand commented 4 years ago

@zigarn Côté framework formation ça serait pas très compliqué (voir L142-145). Par contre ça serait plus embêtant côté markdown puisqu'il faudra utiliser de l'html à la place des titres markdown

<h2 class="question">Comment faire</h2>

Plutôt que

## Comment faire

Faudrait probablement vérifier ce qu'en pense le marketing d'ailleurs ;)

zigarn commented 4 years ago

Ah oui effectivement, on peut pas faire un simple ## Comment faire {.question} ou équivalent dans l’implémentation Markdown

yannbertrand commented 4 years ago

Pas à ma connaissance en tout cas 😕

hgwood commented 4 years ago

Reveal supporte une snytaxe spéciale pour le faire normalement : https://revealjs.com/markdown/#element-attributes

hgwood commented 4 years ago

Shouldn't this be opt-in? Like the 2017 theme was? The Chrome bug that renders blank pages on PDF when the slide overflows is still here. Example with the React training:

image

hgwood commented 4 years ago

Maybe we could add a "theme-2020" and have the "T" key cycle through all 3 themes, and modify the gruntfile to take a --theme option, with 2020 being the default value? What do you think?

yannbertrand commented 4 years ago

Actually I got this issue on pre-2017 & 2017 themes as well. Splitting the slides in smaller ones solved it on my side.

IMO we should focus on adding theme management to Senseï (guidelines compliance, dark-mode, customer themed...) rather than taking more time on the legacy formation-framework.

Maybe keep the issue open if someone absolutely want to use an "up-to-date" theme (will be easier to find).

hgwood commented 4 years ago

OK sounds good. I'll open a PR on sensei then.

hgwood commented 4 years ago

Let's move the discussion to https://github.com/Zenika/sensei/pull/8