Zenika / Zenika-Resume

Markdown editor for resumes.
https://resume.zenika.com
MIT License
4 stars 4 forks source link

:pushpin: pin down npm version #31

Closed hgwood closed 6 years ago

hgwood commented 6 years ago

This is used by Heroku when deploying. Before this change, Heroku would use Node 5.7 as specified in package.json but used a (seemingly) incompatible npm 5.10.0 because of the presence of package-lock.json.

From Heroku build logs:

-----> Installing binaries engines.node (package.json): 5.7 engines.npm (package.json): unspecified (use default)

  Resolving node version 5.7...
  Downloading and installing node 5.7.1...
  Detected package-lock.json: defaulting npm to version 5.x.x
  Bootstrapping npm 5.x.x (replacing 3.6.0)...
  npm 5.10.0 installed

...

-----> Building dependencies Installing node modules (package.json + package-lock) npm ERR! this is not a typed array.

...

-----> Build failed