Zenika / alpine-chrome

Chrome Headless docker images built upon alpine official image
https://hub.docker.com/r/zenika/alpine-chrome
Apache License 2.0
1.83k stars 242 forks source link

Add test hook #135

Closed mecm1993 closed 3 years ago

mecm1993 commented 3 years ago

Closes #20

jlandure commented 3 years ago

Hi @mecm1993 👋

Thanks for your proposal. 👍

For this issue, I would like to enable a more useful "autotest".

For example, we could compare the version written in the README? or launch one of the examples and compare the results.

What do you think? 😊

Thanks again for your contribution.

mecm1993 commented 3 years ago

It sounds good to me, however, I am not sure about testing the examples because the main focus should only be on the alpine-chrome image alone I think it could lead to false-positive in some scenarios. Is that ok with you?

jlandure commented 3 years ago

For info, set -e Exit immediately if a command exits with a non-zero status. Let's try with your proposal and improve the testing part in the future. 👍