search

Zenika / alpine-chrome

Chrome Headless docker images built upon alpine official image
https://hub.docker.com/r/zenika/alpine-chrome
Apache License 2.0
1.82k stars 241 forks source link

Testing Chrome Extension with Puppeteer and Xvfb (Headful) #167

Closed chriscamicas closed 2 years ago

chriscamicas commented 3 years ago

Context

Thank you for your work, this image was really helpful. I want to test a chrome extension, but unfortunately it is not possible in headless mode according to puppeteer official doc. I can confirm, I tried ;-)

Alternatives

Currently, I can run the tests I need with a docker image I've built based on zenika/alpine-chrome:with-puppeteer where I add the installation of Xvfb and start it.

Has the feature been requested before?

No request found

If the feature request is accepted, would you be willing to submit a PR?

Yes, absolutely, I have the code available right away. I prefer to ask before submitting a PR since your repository objectives clearly mention the smallest headless image for e2e test ;)

chriscamicas commented 3 years ago

you can have a look right there: https://github.com/chriscamicas/alpine-chrome/tree/master/with-puppeteer-xvfb

jlandure commented 3 years ago

Hi @chriscamicas 👋

Very interesting! 👍 I suggest to create a PR if you have the time to do it! 💚 You can submit an example here: https://github.com/Zenika/alpine-chrome/tree/master/examples/

WDYT?

Thanks!

chriscamicas commented 3 years ago

Thanks for your message, the PR is created : #174

jlandure commented 3 years ago

Whooo! 🤩 So cool! Thanks a log @chriscamicas for the PR 🎉 I think it will help a lot of users 💪

I review it asap.