Zenika / alpine-chrome

Chrome Headless docker images built upon alpine official image
https://hub.docker.com/r/zenika/alpine-chrome
Apache License 2.0
1.82k stars 241 forks source link

Node 16 Support? #183

Closed wszydlak closed 2 years ago

wszydlak commented 2 years ago

Context

Can this image be published with NodeJS 16 support (together with npm@7)?

Has the feature been requested before?

No

jlandure commented 2 years ago

Hello @wszydlak 👋

First, Sorry for the delay. 😊 Thanks for your idea 💡

Could you help for this? 👍 This is hacktoberfest month. Feel free to contribute and win a tshirt.

Have a good week.

gidztech commented 2 years ago

The latest version of Alpine (3.14) only contains Node 14 in the official repository: https://pkgs.alpinelinux.org/packages?name=nodejs&branch=v3.14. This is presumably because Node 16 only very recently made it to LTS.

Option 1: Wait for the repository to be updated with the updated LTS, which is Node 16 (hopefully soon), and then I think we just need to re-push a new image of what have on master to Docker hub and let the post_push hook push the zenika/alpine-chrome:89-with-node-16 tag. See https://github.com/Zenika/alpine-chrome/blob/master/with-node/hooks/post_push

Option 2: Instead of using the repository, Node JS/NPM can be installed via source code (need to detect hardware architecture for this) or via nvm / fnm.

Option 3: Use a Node image like node:lts-alpine (LTS version of Node and latest Alpine). However, that would give Node to the base image, which may not be appropriate, given that Selenium/Chromedriver don't need Node.

theheuman commented 2 years ago

A new version of alpine (3.15) with node 16 is now available https://pkgs.alpinelinux.org/packages?name=nodejs&branch=v3.15

Tam2 commented 2 years ago

Any updates on an image being pushed with node 16?

hgwood commented 2 years ago

The latest image is available with node 16.