search

Zenkoh1 / pe

0 stars 0 forks source link

Vendor tag disappears after deleting tags #9

Open Zenkoh1 opened 1 week ago

Zenkoh1 commented 1 week ago

How to reproduce

Run delete-tag t/hotel manager f/

Expected

The hotel manager tag is deleted

Actual

Before

image.png

After

image.png

The hotel manager tag and the vendor tag disappears

Additional Information

This can be very confusing for users, as they did not specify to remove Bobby as a vendor, but his vendor tag disappears anyways

soc-pe-bot commented 1 week ago

Team's Response

This does not cause inconvenience to users. Even though the vendor tag disappears, the task list still remains. Upon restart, if there is task present, the person still remains as a vendor which does not hinder normal user operations. However, this is still a bug just with a lower severity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: >This does not cause inconvenience to users.

I feel like it does, as I am going to explain now.

Upon restart, if there is task present, the person still remains as a vendor which does not hinder normal user operations.

It is true that a person suddenly converts back to a vendor if a task is still present. However, I want to make it clear that without restarting the application, the person will still stop being a vendor, as with my original issue.

image.png

Referencing this severity.High issue from the canvas quiz, the current issue at hand is similar. Every time a user wants to delete tags (which is fairly common), they need to restart the app just to restore the vendor status of some people. If a user is told of this bug, ("Hey, everytime you delete tags, you need to restart the application"), they will most likely not want to use WedLinker as this is very inconvenient to all users.

But there is another big issue at hand, the application only restores the vendor status IF they have tasks. While most vendors should have tasks assigned to them, there will always be a few that do not (either new vendors, or vendors whose tasks got deleted to be replaced with new tasks in future). For those people, their vendor status will be lost forever. This will greatly inconvenience all users, as now, they will very commonly, and unintentionally (due to this bug), remove the vendor tag from some vendors every time they delete other tags, which is permanent data loss. Even if the user can still slowly add back all the vendor tags lost, the user is not going to remember every single vendor that existed previously (before the occurrence of the bug) in WedLinker.