Zenmo / zero-web

0 stars 0 forks source link

Survey sanity checks #137

Open Erikvv opened 1 week ago

Erikvv commented 1 week ago

In module "Zummon" add sanity checks and

Sanity checks

Capacities and annual totals:

Booleans:

Quarter-hourly data:

Best IDE to use is https://www.jetbrains.com/idea/nextversion/

naudloomans commented 1 week ago

@AteZenmo @GillisHommen punt van aandacht: wat zijn de minimale inputs die we nodig hebben om een bedrijf te accepteren (jaarverbruik, opwek, en aansluitcapaciteit) of is aanlsuitcapaciteit niet per se nodig?

GillisHommen commented 5 days ago

I would put the upper limit much lower, at 100k, and the lower limit also lower, at something like 5k or even less.

For these two:

I understood 'holes' are defined as extended periods with a delivery of production of 0kWh per timestep? I don't think checking for 0.0 is really a way to identify 'missing data'. Basically all timeseries data should be complete (valid doubles) and it is the responsibility of Energieke Regio to make sure the data is correct or at least feasible. We can do checks on the sum and the min/max values of a timeseries though.

FeedIn can be zero despite having PV; it just means all the production is consumed directly, and not fed back into the grid. Instead you can check that quater-hourly production should not be all zeroes if hasPv is true.

For companies with a battery system this is not necessarily true. (but so far we have had no companies with a battery system)

Erikvv commented 4 days ago

I think for some of the points we can have "severity one" and "severity two" thresholds.

I would put the upper limit much lower, at 100k, and the lower limit also lower, at something like 5k or even less.

Done.

Chargers for heavy duty vehicles can have higher powers, I think we can allow up to ~150kW for normal cases, but this will go up further in the future.

Changed it to max 150 kW for now.

Maybe it's better to check that it's not bigger than the physical connection capacity. (unless there is a big battery, in which case the charger can have more power than the local connection capacity!)

Changed it to "total power of charge points should be below contracted delivery capacity + battery power"

I understood 'holes' are defined as extended periods with a delivery of production of 0kWh per timestep? I don't think checking for 0.0 is really a way to identify 'missing data'. Basically all timeseries data should be complete (valid doubles) and it is the responsibility of Energieke Regio to make sure the data is correct or at least feasible. We can do checks on the sum and the min/max values of a timeseries though.

I think it deserves a warning as I find it unlikely they'll check the entire time series.

FeedIn can be zero despite having PV; it just means all the production is consumed directly, and not fed back into the grid.

I've removed this check.

Instead you can check that quater-hourly production should not be all zeroes if hasPv is true.

I'm not sure if we should assume a production meter is always present.

For companies with a battery system this is not necessarily true. (but so far we have had no companies with a battery system)

Changed it to "every time step in quarter-hourly feed-in should be be less than or equal to production + battery power"

macano commented 1 day ago

if kleinverbruikOrGrootverbruik is Grootverbruik includes Grootverbruik data if kleinverbruikOrGrootverbruik is Kleinverbruik includes Kleinverbruik data