search

Zenmo / zero_engine

This repository contains the 'engine' part of the Zenmo Zero models; the calculation model of the energy system simulation
GNU General Public License v3.0
0 stars 0 forks source link

Energy asset parameters "name" and "energyAssetType" are used inconsistently #61

Closed GillisHommen closed 1 month ago

GillisHommen commented 2 months ago

Energy Asset "name" is used for consumption/production assets to 'assign' the right profile to the assets during simulation. Is there a cleaner way to achieve the same functionality? Can an energy asset 'point' to its own profile? Perhaps create a 'profile pointer' class that contains the profile name and the current value of the used profile?

Similarly, the Energy Asset attribute energyAssetType doesn't have a well defined function; it is used in some cases for switching logic but often has no effect. Can this be cleaned up?

GillisHommen commented 1 month ago

The profilePointer was added in https://github.com/Zenmo/zero_engine/pull/69

Functionalities based on OL_EnergyAssetType are still a bit inconsistent.