search

ZennerIoT / ex_audit

Ecto auditing library that transparently tracks changes and can revert them.
MIT License
369 stars 108 forks source link

Add missing Ecto features like setting default_options/1 #75

Closed MMore closed 3 years ago

MMore commented 3 years ago

Moreover this adds missing Ecto functions like aggregate and reload.

resolves #74

AndriiKlymchuk commented 3 years ago

Hello @MMore. Why do you use edge branch instead of master? Looks like edge is quite outdated right now.

MMore commented 3 years ago

@AndrewKlymchuk Well, initially I did my changes on the 14th of June where master was used for older Ecto versions. edge was for newer ones. Obviously @narrowtux merged edge into master 3 days later (https://github.com/ZennerIoT/ex_audit/commits/master). 🤷‍♂️

AndriiKlymchuk commented 3 years ago

@MMore, got it. Could you please update pr? I'm interested in your fix too.

MMore commented 3 years ago

Currently I have limited capacity and this one works for me. I will update it when I have the time to do it. But the next weeks are packed already. Feel free to extend it yourself in the meantime.

emaiax commented 3 years ago

Hi, @MMore, I hope you're doing well. :)

Would you mind updating your PR with the new changes that are currently in the master branch and using it against your PR instead of edge?

I'm very interested in your fix, but I'm not being able to use it right now. How can I help you? :)

MMore commented 3 years ago

Hi @AndrewKlymchuk and @emaiax, please see my comment in #74. HTH. Let's see when the maintainer merges #78.