search

Zeno-Zr / pe

0 stars 0 forks source link

class diagram contains nonstandard symbols (style) #15

Open Zeno-Zr opened 1 year ago

Zeno-Zr commented 1 year ago

The green c and the red and green shapes meant to represent private and public variables/methods are not part of the class diagram style. this happens throughout the DG

image.png

image.png

image.png

soc-se-bot commented 1 year ago

Team's Response

Addition of green C was part of Plant UML notation.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Icons in class diagrams can be removed

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

As mentioned by my TA, these icons are not allowed in the class diagram and can be removed with hide circle while the other icons can be removed with skinparam classAttributeIconSize 0.

image.png

[original: nus-cs2113-AY2223S2/pe-interim#287] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Addition of green C was part of Plant UML notation that can indeed be removed.

VeryLow severity as it is just a cosmetic bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]