Zeno410 / Climate-Control

A Minecraft mod for changing climate and biomes without chunk boundaries
18 stars 10 forks source link

[1.7.10] Imcompatible with Advent of Ascension dimensions #13

Closed jahtim closed 7 years ago

jahtim commented 7 years ago

I entered a lot of Advent of Ascension dimensions and find that the biome in those dimensions are equal to overworld. No AOA biomes generated in those dimensions, expect for a few dimension where generating is quite normal. I set CCDimension white list to 0, and this still happen. Any idea what's going on ?

jahtim commented 7 years ago

100% reproducable, the stone underground is generating correctly, but the top layer of the dimensions are incorrect , and with wrong biome (ocean, plains, steppe...etc).

jahtim commented 7 years ago

I also using RTG, BOP, Galacticraft (nether and GC dimensions are beheving normally)

jahtim commented 7 years ago

I tested it for more time and find that: if a AoA dimension World Provider use WorldChunkManagerHell then the world generate correctlly. if a AoA dimension World Provider use each dimensions' specific WorldChunkManager(like WorldChunkManagerAbyss, which extends WorldChunkManager as well) then the world generate abnormally.

I might guess that In ClimateControl, method onCreateSpawn() in Dimensionmanager the AOA WorldChunkManager(s) haven't put dimensionid on time. so the dimension id CC got is 0.

Class Dimensionmanager line 295: int dimension = world.provider.dimensionId;

jahtim commented 7 years ago

This should work around with adding the following line to Dimensionmanager line 295 and 326: if(world.provider.getClass().getName().contains("nevermine")) return;

jahtim commented 7 years ago

No, The actual workaround is not using ForgeEventBus when Nevermine generating world. It works for me.