ZenonSeth / logistica

A Minetest item transport and storage mod
Other
1 stars 4 forks source link

minetest complains: set_string to string, hud_elem_type -> type #26

Closed Ocraw closed 3 months ago

Ocraw commented 3 months ago

Minetest 5.9 is verbose about setting a string to nil and HUD element type changing its key (I suppose that's what happened) Seems to run fine on 5.8 too, altho not extensively tested.

Not sure why syncing ended up in the pull request, does it cause issues?

ZenonSeth commented 3 months ago

Not sure why syncing ended up in the pull request, does it cause issues?

It looks like you had your own main which you merged my main into, so the commit is there, but it shouldn't cause issues at all. The diff is fine, aside from my 1 unrelated comment, and an extra commit won't cause an issue.

Ocraw commented 3 months ago

Still uncertain about what I did, but I did something, is it good?