Zepalesque / The-Aether-Redux

An addon to the well-known Minecraft mod, the Aether, adding a variety of content additions, including biomes, accessories, and more!
24 stars 8 forks source link

[Bug]: >>portal sound<< #91

Closed SGZ-Creations closed 3 months ago

SGZ-Creations commented 3 months ago

Minecraft Version

1.19.2

Mod Version

2.0.7d

Forge/Neoforge Version

43.3.2

What happened?

Muting "aether:block.aether_portal.ambient": 0.0, using ESM causes crashes shown in the logs

What was the expected result?

Not to crash When near portal with sound muted

Steps to Reproduce

Have Aether Redux and Extreme sound muffler mod. Mute the "aether:block.aether_portal.ambient": 0.0, be close to portal and when sound is triggered the crash should occur.

Log Output (if applicable)

No response

Crash Report (if applicable)

crash-2024-03-22_22.31.03-client.txt crash-2024-03-22_22.24.23-client.txt crash-2024-03-22_22.15.58-client.txt

Is this a compatibility issue with another mod?

Extreme sound muffler

Additional Context/Information

No response

Make sure to confirm these as well before submitting the report:

Zepalesque commented 3 months ago

hmm, could I have the log file? I'm not seeing anything mentioning redux in the crash log

Zepalesque commented 3 months ago

oh hold on nevermind

Zepalesque commented 3 months ago

this appears to be an issue with the other mod, I suggest reporting to them to have them add a null check to make sure the SoundInstance is not null before setting the volume to 0

Zepalesque commented 3 months ago

right forgot about this yeah so there isn’t a ton I can do for this, like I said before I suggest reporting it to their issue tracker if you haven’t already