Zeph180 / my-things

A console app that helps to keep a record of different types of things you own: books, music albums, movies, and games.
MIT License
0 stars 0 forks source link

https://github.com/users/Zeph180/projects/8 #37

Open Zeph180 opened 1 year ago

Zeph180 commented 1 year ago

We are a team of three people Kigozi Joseph - Team member #1 Ayo Moses - Team member #2 Menekam Rudy - Team member #3

arslanbisharat commented 1 year ago

Hi @Zeph180,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

rustam-tolipov commented 1 year ago

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Developer-512px-10

Highlights

  1. No Linters errors 💯
  2. All requirements are complete 💯

Optional suggestions

No optional suggestions :)

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.