Zephancode / wotlk-warlock

2 stars 0 forks source link

Low rank life tap [BUG] #36

Open Nitrz opened 2 years ago

Nitrz commented 2 years ago

1. Describe the bug

Low rank life tap is providing very low returns. At rank 5 we see normal returns. Rank 2 is giving me about 100 mana per cast.

1.1 To Reproduce

Click life tap from affliction spell book.

Rank 1: image Rank 7: image

Zephancode commented 2 years ago

At lower ranks of spells the spell power coefficient gets diminished, isn't this just what you are observing?

Nitrz commented 2 years ago

What about base value? I should get at least 819 mana, but instead I'm getting 100 mana per cast.

nodddle commented 2 years ago

it is weird that it's not doing what the tooltip says it does. do you have any info about how downranked lifetap worked back in original wotlk?

Nitrz commented 2 years ago

In TBC I'm getting 500-600 mana for rank 1 life tap. Thats 5% of my mana. Rank 2 is giving 1000 or 10% of my mana. My life tap downrank macro is for rank 2.

Zephancode commented 2 years ago

Wrath of the Lich King

https://wowwiki-archive.fandom.com/wiki/Downranking#Downranking_Algorithm

At some point between patch 2.2 and the release of Wrath of the Lich King, the downranking formula was changed again.

Ghostcrawler made the following statement about the downranking formula:

If caster level is less than max caster level, then the penalty = 1.0.
If caster level is at or greater than max caster level, then the penalty = (22 + max level - caster level) / 20.
The penalty is capped at 0. Max caster level per spell is also pretty inconsistent, but it's around 4 levels higher than the level at which you get the spell.
Basically, once the caster is 3 levels higher than the max cast level of the spell, the standard coefficient of the spell is multiplied by that penalty (losing 5% of the coefficient per level), with the coefficient reaching zero when the player is 22 levels higher than the max cast level.