search

ZephyrLabs / InfiniTime-Builder

simple script to help automate and build InfiniTime firmware for the pinetime
GNU General Public License v3.0
18 stars 2 forks source link

Could not build InfiniTime Firmware 1.8.0 with applied Modpack #2

Open explit7 opened 2 years ago

explit7 commented 2 years ago

I openened another issue, same Problem after update to InfiniTime 1.8.0 Can't add digistyle watchface. Thx!

Originally posted by @explit7 in https://github.com/ZephyrLabs/InfiniTime-Builder/issues/1#issuecomment-1008217925

explit7 commented 2 years ago

Unfortunately again the same problem like with 1.6.0 I cant apply watchface modpack....

explit7 commented 2 years ago

`` Updated CMakeLists.txt for 1.8.0 CMakeLists.txt

I changed only the lines, that it could build without errors, please check. For me it works. I could build InfiniTime 1.8.0 with DigiStyle Watchface

explit7 commented 2 years ago

Need to reopen this again... Not working with newer builds...

nonchip commented 2 years ago

@explit7 usually it helps if you actually provide any info beyond "the thing doesn't work when i do a thing" ;)

i'd start with: what exact version of the firmware, what exact version of which modpack, and the actual error messages...

also, referring back to #1, i think you might already guess the issue: you're simply using an incompatible firmware version, so you gotta update the modpack code according to the firmware changes + error messages (compilers are usually pretty good at telling you what's wrong). also people there already told you where to go, might help to do that instead of opening issues in multiple unrelated projects ;)

a suggestion of mine this highlights though: maybe instead of horrible horrible zips full of files, modpacks could be actual patches against a specific version (bonus points if it's a range of git commits so you could select multiple patches of the same "era" and then automatically find & checkout a working release)? that would also mean way less has to break when only a small bit is updated (like adding a new widget to a list, because those are often hardcoded in the original source sadly) or e.g. conflicting full-file changes to lv_config.h, CMakeLists and the like (when all you really want there is a single line addition).

explit7 commented 2 years ago

thanks for the answer, the issue is rather old. problem is solved, whatchface need to be rebuild for newer firmware versions.

another dev, alredy done the job, its somewhere in the infinitime firmware git (i cant find exat link right now, but will update the comment later)

thanks again