search

ZeppelinSolutions / solium-plugin-zeppelin

[DEPRECATED] Solium plugin for Zeppelin audits
MIT License
16 stars 10 forks source link

tests: remove the constructor name checks #27

Closed come-maiz closed 6 years ago

come-maiz commented 6 years ago

We should do something nicer for the tests for static errors. But, I don't want to do that today, so I reported https://github.com/OpenZeppelin/solium-plugin-zeppelin/issues/28

come-maiz commented 6 years ago

We discussed that errors.constructor.name.should.equal("Array") is not the same as errors.should.be.instanceof(Array), because the later would succeed also for objects that inherit from Array. But that could actually be a good thing, we don't care if the class is an array or not, as long as it behaves as an array and includes the error we triggered.

Anyway, more discussion pending for when we solve the opened bug.