search

ZeppelinSolutions / solium-plugin-zeppelin

[DEPRECATED] Solium plugin for Zeppelin audits
MIT License
16 stars 10 forks source link

Added rule for "_" suffix for internal variables #31

Closed viquezclaudio closed 6 years ago

viquezclaudio commented 6 years ago

New rule for "_" suffix for internal variables: variables with no visibility qualifier or private or internal variables. Does not apply for variables in a function

viquezclaudio commented 6 years ago

@elopio You are right, I will add tests for explicit internal and private declarations.

Regarding your question, do you mean creating a rule to reject public variables with underscore suffix ?

come-maiz commented 6 years ago

Thanks @viquezclaudio. With your help and after a few iterations with this rules, we realized that if we required all state variables to be private, we could prefix them with an underscore (like on python), and there will be no conflict with function parameters that will be without underscore. I'm closing this one in favor of #32. I copied your code with a few tweaks, so it would be nice if you can review it.