Properly handle negative index bitmaps

Zequez / reddit-placebot

A bot that paints on Reddit /r/place. Works with multiple accounts, and can work with a remote target file for multiple people with the same objective.

MIT License

227 stars 78 forks source link

Properly handle negative index bitmaps #24

Closed mlindner closed 7 years ago

mlindner commented 7 years ago

Negative index bitmaps are standard across Mac OS X and it's impossible to generate positive index bitmaps as far as I can tell. These filetypes should be supported.

Zequez commented 7 years ago

I think the ideal would be to use the Jimp library (which we currently just use in the generation of the BMP file when downloading the bitmap from Reddit) to just read any file format and use getPixelColor and then try to find the closest color match for the color, to support compressed images.

Zequez commented 7 years ago

Also, is probably not worth it considering /r/place is going to close soon.

Zequez commented 7 years ago

This was fixed, probably with the latest updates that allow to use any kind of file for the target. d5933e7a9c7caeabd7fb9c00c2ce489bf97ff2f8