Debt is not reset upon clicking `Clear Debt` in SGQR popup.

[Zer0Legion]

Expected: The debt with a contact is cleared upon clicking the Clear Debt button. Actual: The debt is not reset. Steps to reproduce:

1. add n/owe1 p/96696969 e/test@test.com a/123123
2. add n/owe2 p/96696969 e/test@test.com a/123123

Observe the index of persons owe1 and owe2. In my case it is 11 and 12.

3. lend 12 $/-999

4. pay 12

5. click Clear Debt button

6. Observe that UI still shows that I owe $999 to person with name of owe2

7. Observe that UI wrongly states that I reset money owed by person owe1 to $0

[nus-pe-bot]

Team's Response

Hi, we apologise for the inconvenience, but this is actually due to the issue that multiple people can share the same phone number, which we actually addressed in our planned enhancements. Making phone number unique will automatically fix this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: I agree that the issue of multiple people sharing the same phone number is mentioned in the planned enhancements.

This also means the team has acknowledged that this issue may cause problems in the future.

However knowing that, the team went on to build a large feature on top of this flawed logic.

This goes against a fundamental concept taught in the course where we should build the product iteratively. The team instead built a feature on top of a flaw that they knew about and chose to "fix later", leading to even more problems down the road.

Additionally, the team has stated that:

this is actually due to the issue that multiple people can share the same phone number

However, a user is not expected to know the source of bugs: The user is only concerned that the bug has happened.

---