Zer0Legion / pe

0 stars 0 forks source link

Confusing constraint in UG #23

Open Zer0Legion opened 7 months ago

Zer0Legion commented 7 months ago

The UG states a constraint for a valid Singaporean number. However nowhere in the UG states that the target audience is for a Singaporean audience. This leads to the constraint being very confusing if the user is for example a student in the US.

image.png

soc-se-bot commented 7 months ago

Team's Response

image.png

In our developer guide, we specified that the target users are NUS students. In addition, using FriendFolio doesn't require you to be in Singapore (we allow non-singaporean numbers in FriendFolio). This feature is a PayNow integration so there has to be a Singaporean number constraint for this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your clarification. Once again, the issue I am raising is regarding the UG, whereas the team is arguing that they have included the relevant information in the DG.

I believe including information is not mutually exclusive between the 2 documents, and that they are separate for a reason.

A user reading the document meant for users (UG) will not be able to extract helpful information as to why Singaporean numbers are emphasized.

The team also does not address the fact that the UG does not have the relevant information, as can be seen in the UG.

image.png


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I disagree with the proposed downgrade of severity. The feature is advertised to be a significant feature in the application, and the team has built many notable features on top of phone numbers. Not explaining why a Singaporean number is needed alienates a significant portion of users as stated in the UG, making some features inaccessible to them and thereby causing a level of inconvenience that cannot be dismissed: ![image.png](https://raw.githubusercontent.com/Zer0Legion/pe/main/files/eb3c23ae-7215-4fbb-a826-2ac8985c73b8.png) Going by the team's line of reasoning, even if the user went above and beyond to read the DG, one would find that regardless, a significant portion of NUS students (international freshmen, exchange students) will be confused by the terminology used.