ZerBea / hcxtools

A small set of tools to convert packets from capture files to hash files for use with Hashcat or John the Ripper.
MIT License
2.02k stars 392 forks source link

Refactor fgetline(), chop(), partial hex2bin() usage #334

Closed RealEnder closed 6 months ago

RealEnder commented 6 months ago

Looked at the code and saw some duplications — we have one and the same functions in different tools, sometimes with a bit of different implementations, which evolved over the time. This is a small attempt for unification and deduplication for several of them. Compile-tested. If you like the approach, I can look further into this.

ZerBea commented 6 months ago

Great, thanks for simplifying the code. Merged.