"Feedback for First Model/Views"

[sumeetjain]

• [x] Methods need full documentation.
• [x] Various cases of incorrect indentation
• [x] HTML is not valid. (Missing a certain closing tag). https://github.com/Zerasolar/06-23-dvd_owners/blob/master/views/mainmenu.erb

[Zerasolar]

Okay updated.

[sumeetjain]

Documentation

• [x] Missing description of parameters: https://github.com/Zerasolar/06-23-dvd_owners/blob/master/database_class_methods.rb#L8-L37
• [x] This is not what this method returns: https://github.com/Zerasolar/06-23-dvd_owners/blob/master/database_class_methods.rb#L58 and https://github.com/Zerasolar/06-23-dvd_owners/blob/master/database_instance_methods.rb#L10

Formatting

• [x] Add a line between https://github.com/Zerasolar/06-23-dvd_owners/blob/master/database_class_methods.rb#L53-L54
• [x] and https://github.com/Zerasolar/06-23-dvd_owners/blob/master/database_class_methods.rb#L74-L75
• [x] and https://github.com/Zerasolar/06-23-dvd_owners/blob/master/models/member.rb#L9-L10
• [x] and https://github.com/Zerasolar/06-23-dvd_owners/blob/master/models/member.rb#L22-L23
• [x] and https://github.com/Zerasolar/06-23-dvd_owners/blob/master/models/member.rb#L35-L36
• [x] and https://github.com/Zerasolar/06-23-dvd_owners/blob/master/views/members/delete_member.erb#L8-L9

Indentation

• [x] https://github.com/Zerasolar/06-23-dvd_owners/blob/master/models/member.rb
• [x] https://github.com/Zerasolar/06-23-dvd_owners/blob/master/controllers/members.rb
• [x] https://github.com/Zerasolar/06-23-dvd_owners/blob/master/views/members/list_members.erb
• [x] https://github.com/Zerasolar/06-23-dvd_owners/blob/master/views/members/member_added.erb
• [x] https://github.com/Zerasolar/06-23-dvd_owners/blob/master/views/members/member_changed.erb

[Zerasolar]

Okay I believe I updated correctly.