search

Zergatul / cheatutils

MIT License
40 stars 16 forks source link

[2.4.0, 1.19.4] Max chat history mixin error - TweakerMore incompatibility #25

Closed tajemniktv closed 1 year ago

tajemniktv commented 1 year ago

Hey, after updating to 2.4.0 it's spitting out error about failing to inject onModifyMaxChatHistory. I'm not really good at reading logs but I'm hoping that these might help figuring out what's going on: https://mclo.gs/aYX2IOk I'm guessing it's some kind of mod-feature conflict.

Cheers!

Zergatul commented 1 year ago

It is conflicting with nochatreports mod. If you can play without it, try removing it

tajemniktv commented 1 year ago

https://mclo.gs/VJw9CNL

Hey, thanks for the info. Disabling it didn't work, although it allowed me to see that tweakermore-mc1.19.4-v3.12.0.jar is responsible for the incompat. I will try tweaking TweakerMore config to disable some of it's functions and see if it works. All of these mods seem to work fine along CheatUtils 2.4.0: image I hope this info helps!

Zergatul commented 1 year ago

Yes... it looks like tweakermore trying to increase chat limit as well. Disabling functions will not help, since mixins work before minecraft classes are loaded into memory. The only thing I can do is to mark some (or all?) mixins as not required, preventing crash. In this case some modules may not work as expected.

tajemniktv commented 1 year ago

If that would only "break" chat related modules then I don't mind that much. I just hope that won't create a wave of issues because "something isn't working" because of an incompatibility... I appreciate your work and help in both creating the mod and resolving this issue!

Zergatul commented 1 year ago

I will not resolve this soon. I have to carefully check mixins one by one and mark some of them as non-required. If you can build mod by yourself you can try edit zergatul.cheatutils.mixins.json file and set defaultRequire to 0.

tajemniktv commented 1 year ago

That is no problem at all, I would like to just say that I'm really grateful for how you are handling this issue and that I really appreciate your instructions!:)

tajemniktv commented 1 year ago

Fallen Breath is trying to fix it on TweakerMore side: https://github.com/Fallen-Breath/tweakermore/commit/c68fda30b163f62d16c3f1c961a337983624e2d0 I'm not closing it yet as dev might want to keep this issue still open (or not, if so you can simply close it for me lol) Cheers and thanks again for the help!<3

Zergatul commented 1 year ago

Ok. These conflicts are always annoying to fix.

Zergatul commented 1 year ago

In 2.4.2 version I made all mixins non-required. Game shouldn't crash at start.

tajemniktv commented 1 year ago

Hey, I can confirm that it's both fixed on TweakerMore side and on CheatUtils side!:) Thanks