search

Zergatul / cheatutils

MIT License
33 stars 11 forks source link

ExcellentEnchants #34

Closed EmptyDagon closed 10 months ago

EmptyDagon commented 10 months ago

Is there any way to use enchantments from ExcellentEnchants plugin in VillagerRoller? As I understand, it is not possible to identify additional enchantments from this plugin either by id or by name.

Zergatul commented 10 months ago

How do you know it is not possible?

EmptyDagon commented 10 months ago

How do you know it is not possible?

I'm sorry, I guess the translator didn't translate the meaning of my words correctly. I meant that I think so, because the api commands to show the name and id didn't work correctly (showed vanilla enchantments, but not additional ones).

EmptyDagon commented 10 months ago

I accidentally closed the comments.....

Zergatul commented 10 months ago

So what you see in the log if you log enchantment names/ids in the system chat?

EmptyDagon commented 10 months ago

The work of this plugin is that it adds additional enchantments to the existing ones, so it shows only all vanilla (example: a book with the enchantment "mending" falls out, and to it in white color in the description attributed to more enchantments).

[25aug.2023 12:33:20.064] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [System] [CHAT] [Roller] minecraft:binding_curse Curse of binding 1 @ 28 --- 280% [25aug.2023 12:33:21.563] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [System] [CHAT] [Roller] minecraft:channeling Channeling 1 @ 8 --- 160%

Zergatul commented 10 months ago

That's strange way to implement custom enchantments. Villager Roller module only see what's possible in vanilla minecraft code. I mean you can add new enchantment with new id and name, and module should be able to work with. But your mod seems like use something another.

EmptyDagon commented 10 months ago

Does that mean there is no way to use Villager Roller with this plugin? And is there any way to see multiple enchantments at one book at once?

Zergatul commented 10 months ago

At current state - no. Villagers only propose single enchantment in vanilla, right?

EmptyDagon commented 10 months ago

Yes, that's correct. Too bad, I really wanted to use your great tool with this plugin

EmptyDagon commented 10 months ago

Should I close this thread?

Zergatul commented 10 months ago

Yes, you can close it