ZerioDev / Music-bot

A complete code to download for a cool Discord music bot !
https://discord.gg/5cGSYV8ZZj
GNU General Public License v3.0
882 stars 1.08k forks source link

[Feature suggestion] Lyrics #242

Closed pendragons-code closed 1 year ago

pendragons-code commented 2 years ago

I know that the lyrics command is in progress, but I would like to suggest an API: some-random-api.ml

while I understand that the command is in development, I think that this is one of the best apis most people can use!

At the same time, I think that whatever API you use, you would most likely run into a common issue, word limits on an embed

While you may be able to add multiple fields and titles (.addfields()), there is a limit of 25 fields. While that alone is very difficult for a song to fill up, it is still possible and the embeds would be really big, annoying people. Therefor, it would seem beneficial to send the embed or link into the direct message of the person who requested it. (or at least ask if they want it in the channel or the dms)

Thank you!

pendragons-code commented 2 years ago

The giant blobs of text and embeds annoying people is a problem that is more problematic for users on mobile.

revot334 commented 2 years ago

only if there where pages 🤔

pendragons-code commented 2 years ago

https://some-random-api.ml/endpoints https://some-random-api.ml/lyrics

Is this what you meant? Also it seems to lead to genius lyrics. It works pretty well, especially since the systems also seems to account for typos.

On Tue, Sep 27, 2022, 07:03 Revot @.***> wrote:

only if there where pages 🤔

— Reply to this email directly, view it on GitHub https://github.com/ZerioDev/Music-bot/issues/242#issuecomment-1258744585, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVEGAZJ6M4YNNYDOTPX7MOLWAITSPANCNFSM6AAAAAAQUVNKEI . You are receiving this because you authored the thread.Message ID: @.***>

pendragons-code commented 1 year ago

only if there where pages thinking

should i close this?

also if you mean pages, just take the contents and divide accordingly.

So let's say the chorus:

"bananananananananananannanananana"

so we can cut the embed by verse, chorus, bridge and whatever since if i am not wrong the thing actually splits it up like that. In an event that it does not, just divide the number of words by the maximum number of words per embed and send that many embeds (adjust for the remainder)

revot334 commented 1 year ago

pages inside discord 🤔

pendragons-code commented 1 year ago

pages inside discord thinking

wdym pages inside discord

RappyTV commented 1 year ago

just put it into the description (character limit is 4096 there)

pendragons-code commented 1 year ago

i did say that before and 4096 ain't long enough for some songs.

On Sat, 29 Oct 2022 at 08:28, RappyTV @.***> wrote:

just put it into the description (character limit is 4096 there)

— Reply to this email directly, view it on GitHub https://github.com/ZerioDev/Music-bot/issues/242#issuecomment-1295661034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVEGAZPGVV4ZPLHB7TSJQSLWFRVUPANCNFSM6AAAAAAQUVNKEI . You are receiving this because you authored the thread.Message ID: @.***>

revot334 commented 1 year ago

its comming

revot334 commented 1 year ago

check out the beta! if you want it now if you prefer to wait v8 will be out in 4 days https://github.com/ZerioDev/Music-bot/tree/beta-(Bugs-are-expected)